The Nightstar Zoo • View topic

View unanswered posts | View active topics

Board index » The Commons » Code Monkeys

All times are UTC - 6 hours [ DST ]

Loop Refactoring?

Moderators: Chalain, Nightstar Staff

Page 1 of 1

[ 3 posts ]

Print view

Previous topic | Next topic

Author

Message

Chalain

Post subject: Loop Refactoring?

Posted: Wed Feb 08, 2006 3:23 pm

Nightstar Graveyard Daemon

Joined: Mon Jun 03, 2002 8:30 pm
Posts: 1071
Location: Wouldn't you rather observe my Velocity?

So, I have a loop that has a precondition and a post condition, and the loop body includes both of these. E.g. the loop goes

Code:

step 1
begin loop
  step 2
  step 1
end loop
step 2

I think it looks horribly inelegant. How do I clean this up?

Code:

# This is mostly pseudoruby.  I don't expect this to pass a syntax checker.
# find all lines beginnig with a '.' and splice them onto the previous line
open input_file
open output_file

prev_line = curr_line = ''
prev_line = input_file.get_line()
while curr_line = input_file.get_line() != File.EOF
  if curr_line =~ /^\s*\./
    prev_line += curr_line
  else
    output_file.write(prev_line)
    prev_line = curr_line
  end
end
output_file.write(prev_line)
close input_file
close output_file

Any ideas?

Top

SomebodyElse

Post subject: Re: Loop Refactoring?

Posted: Wed Feb 08, 2006 11:37 pm

Reptile House Exhibit

Joined: Wed Sep 08, 2004 9:44 pm
Posts: 270

Is there any way to suppress the automatic newline during "output_file.write()"? Then, you could do:

Code:

# Note: I know absolutely nothing about Ruby.  The following code may be horribly incorrect.

open input_file
open output_file

curr_line = input_file.get_line()
output_file.write_no_newline(curr_line)

while curr_line = input_file.get_line() != File.EOF
  if not curr_line =~ /^\s*\./
    output_file.write('')    # Write a newline.
  end

  output_file.write_no_newline(curr_line)
end

close input_file
close output_file

Then again, maybe I've been hacking C too long.

_________________
Healthy Trekkies work out at the He's Dead Gym.

Tech Support Comedy - Comic relief for tech support workers.

Top

Schol-R-LEA

Post subject:

Posted: Mon Feb 13, 2006 7:53 pm

Concession Worker

Joined: Wed Jun 12, 2002 11:16 am
Posts: 1413
Location: People's Republic of Berkeley

While I don't know Ruby that well, a quick look at this tutorial gives a clear solution, using a do block:

Code:

lineAccumuate = ""
File.open("output.txt", "w"), File.open("input.txt, "r").each_line do |output_file, line|
      if line.scan( /^\s*\./) then
            lineAccumulate += line
      else
            output_file.puts lineAccumulate
            lineAccumulate = line
      end
end

I'm not entirely sure you can double up the arguments of a block like I did here, but I gather it is possible. Also, I didn't use any error handling, as I've yet to read up on that aspect of the language.

Alternately, if you can guarantee that the input file is small enough to fit into memory, you could use File.readLines() to slurp the whole file in at once, and then walk through it using the array operators.

Code:

File.open("input.txt", "r") do |input_file| 
      lines = input_file.readLines
end

lines.each do |curr_line|
     line Accumualate = ""
     while curr_line.scan( /^\s*\./) do
           lineAccumulate += curr_line
     end
     output_file.puts(lineAccumulate)
end

_________________
Schol-R-LEA;2 ELF JAM LCF BiWM MGT GS
First Speaker, Last Eristic Church of Finagle and Holy Bisexuality
#define KINSEY (rand() % 7) // Keeper of the Tent Peg of Homosexuality +5
You draw it, we misinterpret it. - Bo Lindbergh // Realitas vestri renuo, sufficioque mei.
"Fundamentalism, not atheism, is the ultimate rejection of faith."

Top

Page 1 of 1

[ 3 posts ]

Board index » The Commons » Code Monkeys

All times are UTC - 6 hours [ DST ]

Who is online

Users browsing this forum: No registered users and 2 guests

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Jump to: